GraphQL Migration #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stigi
force-pushed
the
ullrich/remove-graphql
branch
6 times, most recently
from
fe04702 to
c6abb69
Compare
stigi
commented
Oct 9, 2024
smeijer
approved these changes
Oct 9, 2024
stigi
force-pushed
the
ullrich/remove-graphql
branch
from
6329508 to
15801ed
Compare
|
^^ rebased on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
Resolves #19
Note
This PR depends on other PRs and needs to be rebased on
mainbefore merge:This PR updates the SDK and removes all traces of the
/graphqlendpoint. Notifications are now fetched via the/notificationsendpoint. It's in line with magicbell/magicbell-swift#38 in the Swift SDK.Breaking changes
The breaking changes are mostly around deprecation of
topicsandcategoriesin favor of their singularstopicandcategory.Also the switch away from graphql is major enough that it might justify a major version change. Bumping a major version will also keep the SDKs version in sync with the Swift SDKs version.
Drive By fixes
nilwithnull(because we're in Kotlin land, not Swift)Test Plan
Unit tests are run on CI. New tests to verify behaviour of query parameters have been added
Additional manual testing by pointing the example app to a user with 150 notifications. Verified that loading, paging and predicates work.
Type of Change
Guidelines